Improved metadata layout, better tags accessibility#6463
Merged
TobiGr merged 2 commits intoTeamNewPipe:devfrom Jul 12, 2021
Merged
Improved metadata layout, better tags accessibility#6463TobiGr merged 2 commits intoTeamNewPipe:devfrom
TobiGr merged 2 commits intoTeamNewPipe:devfrom
Conversation
3 tasks
Member
Author
|
People asking for this feature said it suits them, so I'd consider this PR ready for review :-) |
Member
|
Please add before / after screenshots (it should be systematic when changing UI) |
Collaborator
@B0pol You mean this should be added to the template? "Please add before/after screenshots when changing the UI of the app." |
Member
I meant systematic as in not even for newpipe but for all software contributions. |
Member
Author
|
Here is a screenshot @B0pol |
TobiGr
approved these changes
Jul 5, 2021
Contributor
TobiGr
left a comment
TobiGr
left a comment
There was a problem hiding this comment.
Looks good.
Will be merged after 0.21.6 is released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
96dp. I don't know why I chose a percentage in the first place, since using a constant width works better in any layout (e.g. on tablets or TVs).Fixes the following issue(s)
Fixes #6459
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence